Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded google places and maps dependencies to 3.2.0 #257

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgraded google places and maps dependencies to 3.2.0 #257

wants to merge 1 commit into from

Conversation

Doko-Demo-Doa
Copy link

@Doko-Demo-Doa Doko-Demo-Doa commented Oct 1, 2019

With the new release of react-native-maps, Google Maps iOS library is now at 3.2.0, which might cause conflicts between react-native-google-places and react-native-maps

[!] CocoaPods could not find compatible versions for pod "GoogleMaps":
  In Podfile:
    react-native-google-maps (from `../node_modules/react-native-maps`) was resolved to 0.26.0, which depends on
      Google-Maps-iOS-Utils (= 2.1.0) was resolved to 2.1.0, which depends on
        GoogleMaps

    react-native-google-maps (from `../node_modules/react-native-maps`) was resolved to 0.26.0, which depends on
      GoogleMaps (= 3.2.0)

    react-native-google-places (from `../node_modules/react-native-google-places`) was resolved to 3.1.2, which depends on
      GoogleMaps (~> 3.1.0)

Copy link

@suraneti suraneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this merged soon because it has a conflict with the latest react-native-maps.

@julien9999
Copy link

Please merge ASAP

@jdegger
Copy link

jdegger commented Sep 14, 2020

When is this PR due to be merged?

@chensusays
Copy link

@Doko-Demo-Doa @suraneti Is it possible for this to be merged soon?

@Doko-Demo-Doa
Copy link
Author

I don't know, because I don't have merge permission.

@wmonecke
Copy link

Hi! Could this be merged, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants