`eldoc': don't error if a command has no SYNOPSIS #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`esh-help-eldoc-man-minibuffer-string' searches for a "SYNOPSIS" line and then transforms the string following it. This causes an `error' if the command has no synopsis (e.g. `ninja'). Use `-some->>' instead of `->>', fixing the error.
|
@hlissner you should bump |
|
To reproduce:
Everything still works with other commands (e.g. |
|
@tom-tan anything blocking a merge of this PR? Hitting a similar issue as the PR author |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esh-help-eldoc-man-minibuffer-stringsearches for a "SYNOPSIS" line and thentransforms the string following it. This causes an
errorif the command has nosynopsis (e.g.
ninja). Use-some->>instead of->>, fixing the error.