Skip to content

Enable rbac #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rragundez wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable rbac #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eade9b1
Add roles for microsoft provider
rragundez Nov 26, 2025
20ba6ec
Add roles for microsoft provider
rragundez Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fastapi_sso/sso/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class OpenID(pydantic.BaseModel):
display_name: Optional[str] = None
picture: Optional[str] = None
provider: Optional[str] = None

roles: Optional[list[str]] = None

class SecurityWarning(UserWarning):
"""Raised when insecure usage is detected"""
Expand Down
9 changes: 8 additions & 1 deletion fastapi_sso/sso/microsoft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import pydantic

from fastapi_sso.sso.base import DiscoveryDocument, OpenID, SSOBase
from fastapi_sso.sso.base import DiscoveryDocument, OpenID, SSOBase, _decode_id_token
Copy link
Owner

@tomasvotava tomasvotava Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make _decode_id_token public if we need it elsewhere 👌


if TYPE_CHECKING:
import httpx # pragma: no cover
Expand Down Expand Up @@ -45,12 +45,19 @@ async def get_discovery_document(self) -> DiscoveryDocument:
"userinfo_endpoint": f"https://graph.microsoft.com/{self.version}/me",
}

async def get_user_roles(self) -> list[str]:
"""Get user roles from Microsoft ID token."""
token_info = _decode_id_token(self._id_token)
Copy link
Owner

@tomasvotava tomasvotava Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_id_token may be None, please doublecheck the failed workflows

return token_info.get("roles")

async def openid_from_response(self, response: dict, session: Optional["httpx.AsyncClient"] = None) -> OpenID:
token_info = _decode_id_token(self._id_token)
return OpenID(
email=response.get("mail"),
display_name=response.get("displayName"),
provider=self.provider,
id=response.get("id"),
first_name=response.get("givenName"),
last_name=response.get("surname"),
roles=token_info.get("roles"),
)
Loading