Skip to content

remove jmx_enabled option that causes memory leak #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicobrevin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove jmx_enabled option that causes memory leak #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions lib/jruby-rack-metrics.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,23 +13,28 @@ module JrubyRackMetrics
class Monitor
attr_reader :options

def self.start_default_jmx_reporter(metrics_registry=default_metrics_registry)
JmxReporter.startDefault(metrics_registry)
end

def self.default_metrics_registry
Metrics.defaultRegistry
end

def initialize(app, opts = {})
@app = app
@options = default_options.merge(opts)
@timing_unit = TimeUnit::NANOSECONDS
if @options[:jmx_enabled]
JmxReporter.startDefault(metrics_registry)
end
end

def default_options
{ :default_duration_unit => TimeUnit::MILLISECONDS,
:default_rate_unit => TimeUnit::SECONDS,
:jmx_enabled => false }
:metrics_registry => self.class.default_metrics_registry }
end

def metrics_registry
@options[:metrics_registry] ||= Metrics.defaultRegistry
@options[:metrics_registry]
end

def call(env = nil)
Expand Down