fix: use truly unknown extension in test #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'additions' property to TextComponent for link ranges - Add WebP support to MultipartBuilder MIME detection - Add 'explicitContent' property to Logo component - Add ArticleThumbnail component for custom feed images - Add ArticleTitle component with enhanced formatting - Add test for TextComponent additions These changes improve Apple News Format spec compliance.
The testAddImageFileWithUnknownExtension was using .webp which is now a known extension after adding WebP support. Changed to .xyz which is genuinely unknown. Also added explicit test for WebP MIME type detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
testAddImageFileWithUnknownExtensiontest was failing because it used.webpas an "unknown" extension, but commit1fd289cadded WebP support to the MIME type detection.Solution
.xyzwhich is genuinely unknowntestAddImageFileWithWebpExtensiontest to verify WebP supportCI
This should fix the failing test in the previous PR.