[review] move webkit fix

tommilligan · Aug 16, 2024 · 54d27fc · 54d27fc
1 parent a275eb9
commit 54d27fc
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 7 deletions.
diff --git a/compile_assets/scss/admonition.scss b/compile_assets/scss/admonition.scss
@@ -198,10 +198,6 @@ a.admonition-anchor-link {
   &:hover a.admonition-anchor-link {
     display: initial;
   }
-
-  &::-webkit-details-marker {
-    display: none;
-  }
 }
 
 summary.admonition-title {
@@ -226,6 +222,12 @@ summary.admonition-title {
   details[open].admonition > &::after {
     transform: rotate(90deg);
   }
+
+  // Hide details marker for Safari that loves to show it anyway
+  // ref: https://github.com/tommilligan/mdbook-admonish/pull/185
+  &::-webkit-details-marker {
+    display: none;
+  }
 }
 
 :root {

diff --git a/integration/book.toml b/integration/book.toml
@@ -9,7 +9,7 @@ title = "mdbook-admonish-integration"
 
 [preprocessor.admonish]
 command = "mdbook-admonish"
-assets_version = "3.0.2" # do not edit: managed by `mdbook-admonish install`
+assets_version = "3.0.3" # do not edit: managed by `mdbook-admonish install`
 after = ["links"]
 
 [[preprocessor.admonish.custom]]

diff --git a/integration/expected/book.toml b/integration/expected/book.toml
@@ -9,7 +9,7 @@ title = "mdbook-admonish-integration"
 
 [preprocessor.admonish]
 command = "mdbook-admonish"
-assets_version = "3.0.2" # do not edit: managed by `mdbook-admonish install`
+assets_version = "3.0.3" # do not edit: managed by `mdbook-admonish install`
 after = ["links"]
 
 [[preprocessor.admonish.custom]]

diff --git a/src/bin/assets/VERSION b/src/bin/assets/VERSION
@@ -1 +1 @@
-3.0.2
+3.0.3
diff --git a/src/bin/assets/mdbook-admonish.css b/src/bin/assets/mdbook-admonish.css
@@ -106,6 +106,9 @@ details.admonition > summary.admonition-title::after {
 details[open].admonition > summary.admonition-title::after {
   transform: rotate(90deg);
 }
+summary.admonition-title::-webkit-details-marker {
+  display: none;
+}
 
 :root {
   --md-details-icon: url("data:image/svg+xml;charset=utf-8,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24'><path d='M8.59 16.58 13.17 12 8.59 7.41 10 6l6 6-6 6-1.41-1.42Z'/></svg>");