-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #164 from tommilligan/contributing
chore: split contributing guide
- Loading branch information
Showing
2 changed files
with
32 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# Contributing | ||
|
||
## Workflow | ||
|
||
Please submit a PR from a **new branch** in your fork. | ||
Please do not submit a PR from your fork's `main` branch, as it makes collaborating on/editing the branch a pain. | ||
|
||
## Project design | ||
|
||
- Compiled CSS styles are built and committed from SCSS sources. See the `compile_assets` folder for details. | ||
- `mdbook-admonish install` is responsible for delivering additional assets and configuration to a client book. | ||
- `mdbook-admonish` is responsible for preprocessing book data, adding HTML that references compiled classnames. | ||
|
||
## Scripts to get started | ||
|
||
- `./scripts/install` installs other toolchains required for development | ||
- `./scripts/check` runs a full CI check | ||
- `./scripts/rebuild-book` rebuilds the reference book under `./book`. This is useful for integration testing locally. | ||
|
||
## Making breaking changes in CSS | ||
|
||
To make a breaking change in CSS, you should: | ||
|
||
- Update the assets version in `./src/bin/assets/VERSION` | ||
- Update the required assets version specifier in `./src/REQUIRED_ASSETS_VERSION` | ||
|
||
You must make the next `mdbook-admonish` crate version at least a **minor** version bump. | ||
|
||
## Releasing | ||
|
||
Github workflows are setup such that pushing a `vX.Y.Z` tag will trigger a release to be cut. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters