Also move the lines based on descent.

tommyettinger · May 20, 2024 · dc41592 · dc41592
1 parent b85d133
commit dc41592
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/gradle.properties b/gradle.properties
@@ -23,7 +23,7 @@ org.gradle.daemon=true
 org.gradle.configureondemand=false
 gdxVersion=1.12.1
 regexodusVersion=0.1.15
-anim8Version=0.4.2
+anim8Version=0.4.3
 
 SONATYPE_HOST=DEFAULT
 RELEASE_SIGNING_ENABLED=false

diff --git a/src/main/java/com/github/tommyettinger/textra/Font.java b/src/main/java/com/github/tommyettinger/textra/Font.java
@@ -2184,16 +2184,17 @@ else if("sdf".equals(dfType) || "psdf".equals(dfType)) {
         float ascender = atlas.getFloat("ascender", 0.8f);
         descent = size * atlas.getFloat("descender", -0.25f);
         originalCellHeight = cellHeight = size * atlas.getFloat("lineHeight", 1f) + heightAdjust - descent;
-        underY = atlas.getFloat("underlineY", -0.1f);
-        strikeBreadth = underBreadth = atlas.getFloat("underlineThickness", 0.05f);
+        underY = atlas.getFloat("underlineY", -0.1f) - descent / size;
+        strikeBreadth = underBreadth = atlas.getFloat("underlineThickness", 0.25f);
         if(makeGridGlyphs){
-            underLength = strikeLength = 0.2f;
-            underX = strikeX = -0.1f;
+            underLength = strikeLength = 0.05f;
+            underX = strikeX = -0.05f;
         } else {
             underLength = strikeLength = 0.0f;
-            underX = strikeX = -0.4f;
+            underX = strikeX = 0.0f;
         }
-        fancyY = 0.0f;
+        fancyY = -descent / size;
+        strikeY = -0.5f * descent / size;
 
 //        strikeY = ascender * 0.5f;
 

diff --git a/src/test/java/com/github/tommyettinger/textra/TypingShadeUITest.java b/src/test/java/com/github/tommyettinger/textra/TypingShadeUITest.java
@@ -132,7 +132,7 @@ public void changed (ChangeEvent event, Actor actor) {
 		fpsLabel = new TypingLabel("fps: 0    [^][SKY][[citation needed]", skin, "title", title);
 		fpsLabel.setAlignment(Align.topLeft);
 		// configures an example of a TextField in password mode.
-		passwordLabel = new TypingLabel("Textfield in [~]secure[ ] password mode [+ninja][+ninja][+ninja]: ", skin, "title", font);
+		passwordLabel = new TypingLabel("[_]Textfield in [~]secure[ ] [%?error]password mode [+ninja][+ninja][+ninja]: ", skin, "title", font);
 		final TextField passwordTextField = new TextField("", skin);
 		passwordTextField.setMessageText("password");
 		passwordTextField.setPasswordCharacter('*');