feat!: update to node 20 #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: update to node 20 as node 16 is deprecated on GHA.
brunorosa-tomtom
requested review from
KevinDeJong-TomTom,
jstmlr and
maikelvdh
as code owners
|
Thanks alot @brunorosa-tomtom 💯 - as a few slight other changes needed to be applied (and I cannot amend on your fork), I have taken the liberty to create PR #279 with these additional alterations. I am going to close this PR and finalise #279 asap |
|
@KevinDeJong-TomTom no worries! by the way, if I remember correctly there is a per-repo setting to enable branches from forks with a PR open to be edited by upstream maintainers. I don't remember the exact name of the setting, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: update to node 20 as node 16 is deprecated on GHA.