feat: commisery-action support runs triggered by merge_group event #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askalski85
requested review from
KevinDeJong-TomTom,
jstmlr and
maikelvdh
as code owners
|
@KevinDeJong-TomTom , @maikelvdh could you please take a look? |
maikelvdh
approved these changes
Apr 4, 2024
|
Continued under: #287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to be able to run the commisery action during a run for a PR on the Merge Queue.
We can probably assume there is no need to run this check for the merge_group trigger (inside the Merge Queue), there should be no changes to the commits after all status checks are green for the PR, and the PR is just staged for merging (Merge when ready).
From other hand, since the check is fast, it won't hurt.
This PR sends the warning away for runs in the Merge Queue and let consumers decide if they would prefer to run it conditionally only for one event type.