Open
Conversation
Owner
|
Nice work, like the approach so far, do you think you'll have time to implement the things mentioned above?
Great work, thanks for picking this up :) |
Collaborator
Author
I was basing it on the Zeplin mockups, which shows a graphic. And also a graphic if nothing is found, although I think that is unnecessary with an autosuggest setup.
Two keypresses is kind of standard. But easy to change... you're right, it's not using API calls.
No, it was just easy to get started with. It does have a lot of features which we might, or might not, need later (slots for example). |
joshJarr
approved these changes
Apr 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functioning search box. Still with some rough edges.
Distance,Number of treesandNumber of Species, we may have to drop that idea...