Skip to content

Feature/parksearch#73

Open
jalal wants to merge 10 commits intomasterfrom
feature/parksearch
Open

Feature/parksearch#73
jalal wants to merge 10 commits intomasterfrom
feature/parksearch

Conversation

@jalal
Copy link
Collaborator

@jalal jalal commented Apr 19, 2019

Functioning search box. Still with some rough edges.

  • Need to show a "Not found..." message as per Design Guide
  • Not possible to include Distance, Number of trees and Number of Species, we may have to drop that idea...
  • Still too many popup boxes about Geolocation

@jalal jalal requested review from joshJarr and tomwieck April 19, 2019 18:12
@tomwieck
Copy link
Owner

tomwieck commented Apr 24, 2019

Nice work, like the approach so far, do you think you'll have time to implement the things mentioned above?
Few small things

  • I still think all the parks should be shown before you search (if possible), otherwise you're just presented with a blank screen on opening.
  • If we're going to wait for two keypresses (do we need to if it isn't relying on API calls?), this should be made obvious too - 'please enter at least 2 characters' or something.
  • Is there anything that vue-autosuggest specifically gives us? Happy to leave it in as it works well, just feels like something that could be achieved with a standard filter and computed property (https://vuejs.org/v2/guide/list.html#Displaying-Filtered-Sorted-Results)

Great work, thanks for picking this up :)

@jalal
Copy link
Collaborator Author

jalal commented Apr 24, 2019

  • I still think all the parks should be shown before you search (if possible), otherwise you're just presented with a blank screen on opening.

I was basing it on the Zeplin mockups, which shows a graphic. And also a graphic if nothing is found, although I think that is unnecessary with an autosuggest setup.

  • If we're going to wait for two keypresses (do we need to if it isn't relying on API calls?), this should be made obvious too - 'please enter at least 2 characters' or something.

Two keypresses is kind of standard. But easy to change... you're right, it's not using API calls.

No, it was just easy to get started with. It does have a lot of features which we might, or might not, need later (slots for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants