Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update netlink-packet-route to 0.21 #324

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Update netlink-packet-route to 0.21 #324

merged 1 commit into from
Oct 24, 2024
+78 −77

Conversation

odrling
Copy link
Contributor

@odrling odrling commented Oct 14, 2024

Fixes: #303

@strohel
Copy link
Member

strohel commented Oct 21, 2024

Oh, thanks for the PR, @odrling! I quickly skimmed the code and it looked good, but also flagging @bschwind for review.

I've triggered CI run and it surfaced a (boring) clippy + rustfmt lints, could you please fix them? 🙏

@strohel strohel requested a review from bschwind October 21, 2024 09:57
@odrling odrling force-pushed the upgrade-netlink-packet-route branch from 0794031 to 2478fb4 Compare October 21, 2024 10:05
@odrling
Copy link
Contributor Author

odrling commented Oct 21, 2024

I've triggered CI run and it surfaced a (boring) clippy + rustfmt lints, could you please fix them? 🙏

My bad, should be fixed now, the checks pass when I run them locally.

bschwind
bschwind approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The resulting code from the dependency update is a lot cleaner.

strohel
strohel approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@strohel strohel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a more thorough look, this is indeed more type-safe thanks to the new API, nice! Thanks for the much-needed work, @odrling.

I'll go ahead and merge.

@strohel strohel merged commit b2e4149 into tonarino:main Oct 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschwind bschwind bschwind approved these changes

@strohel strohel strohel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Innernet fails with "Decode error occurred: Failed to parse message with type 16"
3 participants
@odrling @strohel @bschwind