feat: impl Compaction
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethe
reviewed
Jul 21, 2024
| Ok(None) | ||
| } | ||
|
|
||
| pub(crate) async fn major_compaction( |
There was a problem hiding this comment.
Too complicated method, please split it to several submethods.
ethe
reviewed
Jul 22, 2024
| let mut stream = MergeStream::<R, FP>::from_vec(streams).await?; | ||
|
|
||
| // Kould: is the capacity parameter necessary? | ||
| let mut builder = R::Columns::builder(8192); |
There was a problem hiding this comment.
0 could be better if there is not a number, or we could provider a new method to create 0 capacity record batch builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.