-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for running individual tests using karma --grep option #8
Open
jvalkeejarvi
wants to merge
26
commits into
tonini:master
Choose a base branch
from
jvalkeejarvi:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fail when string is not found on describe/it line - Move error handling to calling function - Show error with red font face
Set default-directory in let instead of using setq. Using setq breaks find-file and other functions that rely on default-directory.
Previously it was possible to jump to test file only
jvalkeejarvi
force-pushed
the
master
branch
from
September 20, 2018 06:53
03519c4
to
43be383
Compare
jvalkeejarvi
force-pushed
the
master
branch
from
September 20, 2018 07:41
63ca64d
to
64d36ae
Compare
- Use only 25.3 and 26.1
jvalkeejarvi
force-pushed
the
master
branch
from
September 20, 2018 07:49
64d36ae
to
008d606
Compare
That way tests are easier to run within existing Emacs instance, only helpers need to be loaded before tests file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.