Relax types-docutils version constraint
#418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
==========================================
+ Coverage 73.68% 73.75% +0.06%
==========================================
Files 43 43
Lines 1140 1143 +3
==========================================
+ Hits 840 843 +3
Misses 300 300 ☔ View full report in Codecov by Sentry. |
tony
force-pushed
the
docutils-types
branch
6 times, most recently
from
37928c1 to
a248d8b
Compare
tony
force-pushed
the
docutils-types
branch
2 times, most recently
from
b26b109 to
8c92bdb
Compare
src/django_docutils/lib/roles/common.py:134: error: Too many arguments for "Text" [call-arg] src/django_docutils/lib/metadata/extract.py:57: error: Need more than 0 values to unpack (2 expected) [misc] src/django_docutils/lib/publisher.py:36: error: Need type annotation for "reader" [var-annotated] src/django_docutils/lib/publisher.py:48: error: Unused "type: ignore" comment [unused-ignore] src/django_docutils/lib/publisher.py:50: error: Unused "type: ignore" comment [unused-ignore] src/django_docutils/lib/publisher.py:124: error: Returning Any from function declared to return "document" [no-any-return] Found 6 errors in 3 files (checked 55 source files)
src/django_docutils/template.py:71: error: Redundant cast to "str" [redundant-cast] raises locally, but not on CI (?) even though the system has the same versions across the board.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supposedly fixes: