forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Lens] align formatters for point and range annotations (elastic#177199)
## Summary Resolves partially elastic#176768 Range annotations tooltip before: <img width="547" alt="Screenshot 2024-02-19 at 15 12 55" src="https://github.com/elastic/kibana/assets/4283304/59c493ab-903b-4c22-a02a-947496861c32"> 1. Aligning the formatters Right now we use an advanced setting `dateFormat` to set a formatter for point annotation, but we use a chart axis formatter to set a formatter for range annotation. The second one doesn't really make sense and I would consider this to be a bug, so I aligned them. The original ask from Observability team is also to allow pass a custom formatter, but that's a slightly bigger ask so I've decided to not include it in this PR. 2. Aligning the look I also don't like how range annotation tooltip looked like so I decided to align it too to the point one. Here's how point annotation tooltip looks like: <img width="552" alt="Screenshot 2024-02-19 at 15 11 27" src="https://github.com/elastic/kibana/assets/4283304/39932ef1-958e-4ed9-82c0-3339ecd9f7e7"> Here's how range annotation tooltip looks like after the changes: <img width="621" alt="Screenshot 2024-02-19 at 15 11 35" src="https://github.com/elastic/kibana/assets/4283304/50d7da57-0972-4a5c-be1e-65da2121fa36">
- Loading branch information
Showing
3 changed files
with
31 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters