Skip to content

Commit

Permalink
Move to EA (elastic#170824)
Browse files Browse the repository at this point in the history
## Summary

This PR is simply moving the `risk_engine` folder into the
`entity_analytics` folder, to be able better consolidate future
architecture modules like `asset_criticality` and potential others
  • Loading branch information
nkhristinin authored Nov 9, 2023
1 parent b86e741 commit 55d94c7
Show file tree
Hide file tree
Showing 65 changed files with 67 additions and 67 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -1436,7 +1436,7 @@ x-pack/plugins/security_solution/public/entity_analytics @elastic/security-entit
x-pack/plugins/security_solution/public/explore/components/risk_score @elastic/security-entity-analytics
x-pack/plugins/security_solution/public/overview/pages/entity_analytics.tsx @elastic/security-entity-analytics
x-pack/plugins/security_solution/public/overview/components/entity_analytics
x-pack/plugins/security_solution/server/lib/risk_engine @elastic/security-entity-analytics
x-pack/plugins/security_solution/server/lib/entity_analytics @elastic/security-entity-analytics
x-pack/plugins/security_solution/server/lib/risk_score @elastic/security-entity-analytics
x-pack/test/detection_engine_api_integration/security_and_spaces/group10/risk_engine @elastic/security-entity-analytics

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import type {
GetRiskEngineStatusResponse,
InitRiskEngineResponse,
DisableRiskEngineResponse,
} from '../../../server/lib/risk_engine/types';
} from '../../../server/lib/entity_analytics/risk_engine/types';
import type { RiskScorePreviewRequestSchema } from '../../../common/risk_engine/risk_score_preview/request_schema';

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { useInvalidateRiskEngineStatusQuery } from './use_risk_engine_status';
import type {
EnableRiskEngineResponse,
EnableDisableRiskEngineErrorResponse,
} from '../../../../server/lib/risk_engine/types';
} from '../../../../server/lib/entity_analytics/risk_engine/types';

export const DISABLE_RISK_ENGINE_MUTATION_KEY = ['POST', 'DISABLE_RISK_ENGINE'];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { useInvalidateRiskEngineStatusQuery } from './use_risk_engine_status';
import type {
EnableRiskEngineResponse,
EnableDisableRiskEngineErrorResponse,
} from '../../../../server/lib/risk_engine/types';
} from '../../../../server/lib/entity_analytics/risk_engine/types';
export const ENABLE_RISK_ENGINE_MUTATION_KEY = ['POST', 'ENABLE_RISK_ENGINE'];

export const useEnableRiskEngineMutation = (options?: UseMutationOptions<{}>) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { useInvalidateRiskEngineStatusQuery } from './use_risk_engine_status';
import type {
InitRiskEngineResponse,
InitRiskEngineError,
} from '../../../../server/lib/risk_engine/types';
} from '../../../../server/lib/entity_analytics/risk_engine/types';

export const INIT_RISK_ENGINE_STATUS_KEY = ['POST', 'INIT_RISK_ENGINE'];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import type {

import { getEndpointAuthzInitialStateMock } from '../../../../../common/endpoint/service/authz/mocks';
import type { EndpointAuthz } from '../../../../../common/endpoint/types/authz';
import { riskEngineDataClientMock } from '../../../risk_engine/risk_engine_data_client.mock';
import { riskEngineDataClientMock } from '../../../entity_analytics/risk_engine/risk_engine_data_client.mock';

export const createMockClients = () => {
const core = coreMock.createRequestHandlerContext();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
ALERT_RISK_SCORE,
ALERT_RULE_NAME,
} from '@kbn/rule-registry-plugin/common/technical_rule_data_field_names';
import { RiskCategories } from '../../../common/risk_engine';
import { RiskCategories } from '../../../../common/risk_engine';
import type {
CalculateRiskScoreAggregations,
CalculateScoresResponse,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ import type {
IdentifierType,
RiskWeights,
RiskScore,
} from '../../../common/risk_engine';
import { RiskCategories } from '../../../common/risk_engine';
import { withSecuritySpan } from '../../utils/with_security_span';
} from '../../../../common/risk_engine';
import { RiskCategories } from '../../../../common/risk_engine';
import { withSecuritySpan } from '../../../utils/with_security_span';
import { getAfterKeyForIdentifierType, getFieldForIdentifierAgg } from './helpers';
import {
buildCategoryCountDeclarations,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
* 2.0.
*/
import type { FieldMap } from '@kbn/alerts-as-data-utils';
import type { IdentifierType } from '../../../common/risk_engine';
import { RiskScoreEntity, riskScoreBaseIndexName } from '../../../common/risk_engine';
import type { IdentifierType } from '../../../../common/risk_engine';
import { RiskScoreEntity, riskScoreBaseIndexName } from '../../../../common/risk_engine';
import type { IIndexPatternString } from './utils/create_datastream';

const commonRiskFields: FieldMap = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* 2.0.
*/

import type { AfterKey, AfterKeys, IdentifierType } from '../../../common/risk_engine';
import type { AfterKey, AfterKeys, IdentifierType } from '../../../../common/risk_engine';
import type { CalculateAndPersistScoresResponse } from './types';

export const getFieldForIdentifierAgg = (identifierType: IdentifierType): string =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jest.mock('./utils/create_datastream', () => ({
createDataStream: jest.fn(),
}));

jest.mock('../risk_score/transform/helpers/transforms', () => ({
jest.mock('../../risk_score/transform/helpers/transforms', () => ({
createAndStartTransform: jest.fn(),
}));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ import {
import { createDataStream } from './utils/create_datastream';
import type { RiskEngineDataWriter as Writer } from './risk_engine_data_writer';
import { RiskEngineDataWriter } from './risk_engine_data_writer';
import type { InitRiskEngineResult } from '../../../common/risk_engine';
import type { InitRiskEngineResult } from '../../../../common/risk_engine';
import {
RiskEngineStatus,
getRiskScoreLatestIndex,
MAX_SPACES_COUNT,
RiskScoreEntity,
} from '../../../common/risk_engine';
} from '../../../../common/risk_engine';
import {
getLegacyTransforms,
getLatestTransformId,
Expand All @@ -48,7 +48,7 @@ import {
import { getRiskInputsIndex } from './get_risk_inputs_index';
import { removeRiskScoringTask, startRiskScoringTask } from './tasks';
import { createIndex } from './utils/create_index';
import { bulkDeleteSavedObjects } from '../risk_score/prebuilt_saved_objects/helpers/bulk_delete_saved_objects';
import { bulkDeleteSavedObjects } from '../../risk_score/prebuilt_saved_objects/helpers/bulk_delete_saved_objects';

interface InitOpts {
namespace: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import type { BulkOperationContainer } from '@elastic/elasticsearch/lib/api/types';
import type { Logger, ElasticsearchClient } from '@kbn/core/server';
import type { IdentifierType, RiskScore } from '../../../common/risk_engine';
import type { IdentifierType, RiskScore } from '../../../../common/risk_engine';

interface WriterBulkResponse {
errors: string[];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

import type { RiskScoreService } from './risk_score_service';
import type { RiskScore } from '../../../common/risk_engine';
import type { RiskScore } from '../../../../common/risk_engine';

const createRiskScoreMock = (overrides: Partial<RiskScore> = {}): RiskScore => ({
'@timestamp': '2023-02-15T00:15:19.231Z',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* 2.0.
*/

import { RiskWeightTypes, RiskCategories } from '../../../common/risk_engine';
import { RiskWeightTypes, RiskCategories } from '../../../../common/risk_engine';
import {
buildCategoryAssignment,
buildCategoryWeights,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import type {
RiskCategoryRiskWeight,
RiskWeight,
RiskWeights,
} from '../../../common/risk_engine';
import { RiskCategories, RiskWeightTypes } from '../../../common/risk_engine';
} from '../../../../common/risk_engine';
import { RiskCategories, RiskWeightTypes } from '../../../../common/risk_engine';

const RISK_CATEGORIES = Object.values(RiskCategories);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
import { taskManagerMock } from '@kbn/task-manager-plugin/server/mocks';
import { riskEngineDisableRoute } from './risk_engine_disable_route';

import { RISK_ENGINE_DISABLE_URL } from '../../../../common/constants';
import { RISK_ENGINE_DISABLE_URL } from '../../../../../common/constants';
import {
serverMock,
requestContextMock,
requestMock,
} from '../../detection_engine/routes/__mocks__';
} from '../../../detection_engine/routes/__mocks__';
import { riskEngineDataClientMock } from '../risk_engine_data_client.mock';

describe('risk score disable route', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
import type { StartServicesAccessor } from '@kbn/core/server';
import { buildSiemResponse } from '@kbn/lists-plugin/server/routes/utils';
import { transformError } from '@kbn/securitysolution-es-utils';
import { RISK_ENGINE_DISABLE_URL, APP_ID } from '../../../../common/constants';
import { RISK_ENGINE_DISABLE_URL, APP_ID } from '../../../../../common/constants';
import type { StartPlugins } from '../../../../plugin';
import type { SecuritySolutionPluginRouter } from '../../../../types';
import { TASK_MANAGER_UNAVAILABLE_ERROR } from './translations';
import type { StartPlugins } from '../../../plugin';
import type { SecuritySolutionPluginRouter } from '../../../types';

export const riskEngineDisableRoute = (
router: SecuritySolutionPluginRouter,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
import { taskManagerMock } from '@kbn/task-manager-plugin/server/mocks';
import { riskEngineEnableRoute } from './risk_engine_enable_route';

import { RISK_ENGINE_ENABLE_URL } from '../../../../common/constants';
import { RISK_ENGINE_ENABLE_URL } from '../../../../../common/constants';
import {
serverMock,
requestContextMock,
requestMock,
} from '../../detection_engine/routes/__mocks__';
} from '../../../detection_engine/routes/__mocks__';
import { riskEngineDataClientMock } from '../risk_engine_data_client.mock';

describe('risk score enable route', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
import type { StartServicesAccessor } from '@kbn/core/server';
import { buildSiemResponse } from '@kbn/lists-plugin/server/routes/utils';
import { transformError } from '@kbn/securitysolution-es-utils';
import { RISK_ENGINE_ENABLE_URL, APP_ID } from '../../../../common/constants';
import { RISK_ENGINE_ENABLE_URL, APP_ID } from '../../../../../common/constants';
import { TASK_MANAGER_UNAVAILABLE_ERROR } from './translations';
import type { StartPlugins } from '../../../plugin';
import type { SecuritySolutionPluginRouter } from '../../../types';
import type { StartPlugins } from '../../../../plugin';
import type { SecuritySolutionPluginRouter } from '../../../../types';

export const riskEngineEnableRoute = (
router: SecuritySolutionPluginRouter,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
import type { StartServicesAccessor } from '@kbn/core/server';
import { buildSiemResponse } from '@kbn/lists-plugin/server/routes/utils';
import { transformError } from '@kbn/securitysolution-es-utils';
import { RISK_ENGINE_INIT_URL, APP_ID } from '../../../../common/constants';
import type { StartPlugins } from '../../../plugin';
import { RISK_ENGINE_INIT_URL, APP_ID } from '../../../../../common/constants';
import type { StartPlugins } from '../../../../plugin';
import { TASK_MANAGER_UNAVAILABLE_ERROR } from './translations';
import type { SecuritySolutionPluginRouter } from '../../../types';
import type { SecuritySolutionPluginRouter } from '../../../../types';

export const riskEngineInitRoute = (
router: SecuritySolutionPluginRouter,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@

import { buildSiemResponse } from '@kbn/lists-plugin/server/routes/utils';
import { transformError } from '@kbn/securitysolution-es-utils';
import { RISK_ENGINE_STATUS_URL, APP_ID } from '../../../../common/constants';
import { RISK_ENGINE_STATUS_URL, APP_ID } from '../../../../../common/constants';

import type { SecuritySolutionPluginRouter } from '../../../types';
import type { SecuritySolutionPluginRouter } from '../../../../types';

export const riskEngineStatusRoute = (router: SecuritySolutionPluginRouter) => {
router.versioned
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ import { riskScoreCalculationRoute } from './risk_score_calculation_route';

import { loggerMock } from '@kbn/logging-mocks';

import { RISK_SCORE_CALCULATION_URL } from '../../../../common/constants';
import { RISK_SCORE_CALCULATION_URL } from '../../../../../common/constants';
import {
serverMock,
requestContextMock,
requestMock,
} from '../../detection_engine/routes/__mocks__';
} from '../../../detection_engine/routes/__mocks__';
import { riskScoreServiceFactory } from '../risk_score_service';
import { riskScoreServiceMock } from '../risk_score_service.mock';
import { getRiskInputsIndex } from '../get_risk_inputs_index';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ import {
APP_ID,
DEFAULT_RISK_SCORE_PAGE_SIZE,
RISK_SCORE_CALCULATION_URL,
} from '../../../../common/constants';
import { riskScoreCalculationRequestSchema } from '../../../../common/risk_engine/risk_score_calculation/request_schema';
import type { SecuritySolutionPluginRouter } from '../../../types';
import { buildRouteValidation } from '../../../utils/build_validation/route_validation';
} from '../../../../../common/constants';
import { riskScoreCalculationRequestSchema } from '../../../../../common/risk_engine/risk_score_calculation/request_schema';
import type { SecuritySolutionPluginRouter } from '../../../../types';
import { buildRouteValidation } from '../../../../utils/build_validation/route_validation';
import { riskScoreServiceFactory } from '../risk_score_service';
import { getRiskInputsIndex } from '../get_risk_inputs_index';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@

import { loggerMock } from '@kbn/logging-mocks';

import { RISK_SCORE_PREVIEW_URL } from '../../../../common/constants';
import { RiskCategories, RiskWeightTypes } from '../../../../common/risk_engine';
import { RISK_SCORE_PREVIEW_URL } from '../../../../../common/constants';
import { RiskCategories, RiskWeightTypes } from '../../../../../common/risk_engine';
import {
serverMock,
requestContextMock,
requestMock,
} from '../../detection_engine/routes/__mocks__';
} from '../../../detection_engine/routes/__mocks__';
import { getRiskInputsIndex } from '../get_risk_inputs_index';
import { riskScoreServiceFactory } from '../risk_score_service';
import { riskScoreServiceMock } from '../risk_score_service.mock';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ import {
APP_ID,
DEFAULT_RISK_SCORE_PAGE_SIZE,
RISK_SCORE_PREVIEW_URL,
} from '../../../../common/constants';
import { riskScorePreviewRequestSchema } from '../../../../common/risk_engine/risk_score_preview/request_schema';
import type { SecuritySolutionPluginRouter } from '../../../types';
import { buildRouteValidation } from '../../../utils/build_validation/route_validation';
} from '../../../../../common/constants';
import { riskScorePreviewRequestSchema } from '../../../../../common/risk_engine/risk_score_preview/request_schema';
import type { SecuritySolutionPluginRouter } from '../../../../types';
import { buildRouteValidation } from '../../../../utils/build_validation/route_validation';
import { riskScoreServiceFactory } from '../risk_score_service';
import { getRiskInputsIndex } from '../get_risk_inputs_index';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
} from '@kbn/core/server';
import { addSpaceIdToPath } from '@kbn/spaces-plugin/server';

import type { Range } from '../../../../common/risk_engine';
import type { Range } from '../../../../../common/risk_engine';

export const convertDateToISOString = (dateString: string): string => {
const date = datemath.parse(dateString);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ import type {
TaskManagerStartContract,
} from '@kbn/task-manager-plugin/server';
import type { AnalyticsServiceSetup } from '@kbn/core-analytics-server';
import type { AfterKeys, IdentifierType } from '../../../../common/risk_engine';
import type { StartPlugins } from '../../../plugin';
import type { AfterKeys, IdentifierType } from '../../../../../common/risk_engine';
import type { StartPlugins } from '../../../../plugin';
import { type RiskScoreService, riskScoreServiceFactory } from '../risk_score_service';
import { RiskEngineDataClient } from '../risk_engine_data_client';
import { isRiskScoreCalculationComplete } from '../helpers';
Expand All @@ -30,12 +30,12 @@ import {
} from './state';
import { INTERVAL, SCOPE, TIMEOUT, TYPE, VERSION } from './constants';
import { buildScopedInternalSavedObjectsClientUnsafe, convertRangeToISO } from './helpers';
import { RiskScoreEntity } from '../../../../common/risk_engine/types';
import { RiskScoreEntity } from '../../../../../common/risk_engine/types';
import {
RISK_SCORE_EXECUTION_SUCCESS_EVENT,
RISK_SCORE_EXECUTION_ERROR_EVENT,
RISK_SCORE_EXECUTION_CANCELLATION_EVENT,
} from '../../telemetry/event_based/events';
} from '../../../telemetry/event_based/events';

const logFactory =
(logger: Logger, taskId: string) =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import type {
Range,
RiskEngineStatus,
RiskScore,
} from '../../../common/risk_engine';
} from '../../../../common/risk_engine';

export interface CalculateScoresParams {
afterKeys: AfterKeys;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/
import type { SavedObject, SavedObjectsClientContract } from '@kbn/core/server';

import { getAlertsIndex } from '../../../../common/utils/risk_score_modules';
import { getAlertsIndex } from '../../../../../common/utils/risk_score_modules';
import type { RiskEngineConfiguration } from '../types';
import { riskEngineConfigurationTypeName } from '../saved_object';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ import type {
TransformPutTransformRequest,
TransformGetTransformStatsTransformStats,
} from '@elastic/elasticsearch/lib/api/types';
import { RiskScoreEntity } from '../../../../common/search_strategy';
import { RiskScoreEntity } from '../../../../../common/search_strategy';
import {
getRiskScorePivotTransformId,
getRiskScoreLatestTransformId,
} from '../../../../common/utils/risk_score_modules';
} from '../../../../../common/utils/risk_score_modules';

export const getLegacyTransforms = async ({
namespace,
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/server/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ import {
} from '../common/endpoint/constants';

import { AppFeaturesService } from './lib/app_features_service/app_features_service';
import { registerRiskScoringTask } from './lib/risk_engine/tasks/risk_scoring_task';
import { registerRiskScoringTask } from './lib/entity_analytics/risk_engine/tasks/risk_scoring_task';
import { registerProtectionUpdatesNoteRoutes } from './endpoint/routes/protection_updates_note';
import { latestRiskScoreIndexPattern, allRiskScoreIndexPattern } from '../common/risk_engine';
import { isEndpointPackageV2 } from '../common/endpoint/utils/package_v2';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import type {
import type { Immutable } from '../common/endpoint/types';
import type { EndpointAuthz } from '../common/endpoint/types/authz';
import type { EndpointAppContextService } from './endpoint/endpoint_app_context_services';
import { RiskEngineDataClient } from './lib/risk_engine/risk_engine_data_client';
import { RiskEngineDataClient } from './lib/entity_analytics/risk_engine/risk_engine_data_client';

export interface IRequestContextFactory {
create(
Expand Down
Loading

0 comments on commit 55d94c7

Please sign in to comment.