Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Image Compression #30

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add: Image Compression #30

wants to merge 7 commits into from

Conversation

abbasidaniyal
Copy link
Contributor

@abbasidaniyal abbasidaniyal commented Mar 8, 2020

I have implemented a basic resizing function. It resizes the image to a fixed max-width and then resizes the height accordingly.
Let me know you thoughts on this @tonythomas01 @srish
fixes #18

@tonythomas01
Copy link
Owner

To be honest, I would want to make this optional actually. Most people would not want to do this as Wikimedia Commons welcome images in total size.

@abbasidaniyal
Copy link
Contributor Author

abbasidaniyal commented Mar 14, 2020

To be honest, I would want to make this optional actually. Most people would not want to do this as Wikimedia Commons welcome images in total size.

I have added a checkbox field before the upload button. If checked, we will be resizing the image, else original image will be uploaded!

@abbasidaniyal abbasidaniyal changed the title WIP: Image Compression Add: Image Compression Mar 14, 2020
@abbasidaniyal
Copy link
Contributor Author

@tonythomas01 Should I try some other approach for this?

@tonythomas01
Copy link
Owner

Sorry for the late reply, but now that we have the setup in place, lets make sure to add this to a future user study or something like that. We have to evaluate if people really like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compress images before upload
2 participants