Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot disable webhooks via .Values.webhook.pvcMutatingWebhook.enabled #271

Closed
wparr-circle opened this issue Jul 8, 2024 · 1 comment · Fixed by #272
Closed

Cannot disable webhooks via .Values.webhook.pvcMutatingWebhook.enabled #271

wparr-circle opened this issue Jul 8, 2024 · 1 comment · Fixed by #272
Labels
bug Something isn't working

Comments

@wparr-circle
Copy link
Contributor

Describe the bug
The mutating webhook configuration is removed when .Values.webhook.pvcMutatingWebhook.enabled is set false. However, the certificate volume sourced from a the tls type secret is still required.
This appears to be a fault in the source, where the webhook server itself is not optional. See:

It would be great to make this optional.
Specifically with the generated webhook cert, we found that it resulted in a container config error due to the self signed cert created during the helm install was not provisioned at allwhen .Values.webhook.pvcMutatingWebhook.enabled was set false.

Environments

To Reproduce
Steps to reproduce the behavior:

  1. Install with the following helm values:
  webhook:
    pvcMutatingWebhook:
      enabled: false
    certificate:
      generate: true
  1. This renders a deploy without the mutating webhook configuration, and the secret used for certs
  2. Pods fail with a ContainerConfig error

Expected behavior
When .Values.webhook.pvcMutatingWebhook.enabled is set, neither the cert manager or generated certificate should be rendered.
The deployment should not mount the certificate secret.
The application should be able to start fine without the cert directory.

Additional context
Add any other context about the problem here.

@wparr-circle wparr-circle added the bug Something isn't working label Jul 8, 2024
@peng225 peng225 moved this from To do to In progress in Development Jul 9, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Development Jul 16, 2024
@tekicode
Copy link

Any chance we could get a new release with this functionality? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants