fix: optionally disable the webhook server #272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271
When
.Values.webhook.pvcMutatingWebhook.enabled
is set false, ensure that any of the configuration related to the webhook server is not rendered. ie. cert manager certificate / issuer, deployment volume mount from secret etc.This is supplemented with a new option
--webhook-enabled
- which by default is set true, to mirror existing behaviour. When it is explicitly set false, for example when.Values.webhook.pvcMutatingWebhook.enabled
is set false the webhook server will not be configured.ie.