add support for K8s metrics API as a source of PVC usage data #242
+311
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushitora-anqou
requested changes
Feb 7, 2024
llamerada-jp
requested review from
llamerada-jp
and removed request for
pluser
ushitora-anqou
requested changes
Feb 8, 2024
llamerada-jp
requested changes
Feb 8, 2024
There was a problem hiding this comment.
- Since we referred to the following PR, could you please leave a comment in the PR or the commit message?
add support for K8s metrics API as a source of PVC usage data #193 - Would you please split the code of metrics_client.go into metrics_client.go and prometheus_client.go?
ushitora-anqou
requested changes
Feb 9, 2024
Signed-off-by: Vladislav Tropnikov <vladislav.tropnikov@genestack.com>
Done |
ushitora-anqou
approved these changes
Feb 13, 2024
|
LGTM for codes.
Would you please just update this point? |
llamerada-jp
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.