Fix concurrent map writes bug of K8s metrics API client #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pvc-autoresizer can use Prometheus or the K8s metrics API as sources of metrics to determine whether a PVC needs to be resized. There is a concurrent map access bug in the K8s metrics API client implementation, which causes the pvc-autoresizer to crash. This commit fixes this issue. Signed-off-by: Daichi Mukai <daichi-mukai@cybozu.co.jp>
daichimukai
force-pushed
the
fix-k8s-metrics-api-concurrent-map-writes
branch
from
f9e1160
to
114a3d8
Compare
cupnes
approved these changes
Jul 8, 2024
toshipp
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug reported in #266. Thanks @Mihirkumarsingh for reporting!