Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Configuration of Storage Defaults #287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable Configuration of Storage Defaults #287

wants to merge 1 commit into from

Conversation

josephangbc
Copy link
Contributor

closes #286

@josephangbc josephangbc mentioned this pull request Oct 24, 2024
Open
@josephangbc josephangbc force-pushed the make-defaults-configurable branch 4 times, most recently from 6ab0578 to f82a8b5 Compare November 5, 2024 15:55
@josephangbc
make defaults configurable
71d8867 
Signed-off-by: Joseph Ang <josephangbc@gmail.com>
@josephangbc
Copy link
Contributor Author

josephangbc commented Nov 6, 2024 •
edited
Loading

PvcStorageLimit function will return the default storage limit DefaultLimit . But to maintain backward compatibility, DefaultLimit is set to 0Gi, so that behaviour for PVCs without StorageLimitAnnotation will be kept consistent.

For some reason, the e2e tests seem to keep failing due to timeout, different runs fail on separate occasions, does rerunning the job help?

@josephangbc josephangbc marked this pull request as ready for review November 6, 2024 02:34
@josephangbc josephangbc requested a review from a team as a code owner November 6, 2024 02:34
@daichimukai
Copy link
Contributor

We are postponing the review since we'd like to discuss the feature first. See #286 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daichimukai daichimukai Awaiting requested review from daichimukai daichimukai is a code owner automatically assigned from topolvm/reviewers

@toshipp toshipp Awaiting requested review from toshipp toshipp is a code owner automatically assigned from topolvm/reviewers

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Development
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Configuration of Storage Defaults
2 participants
@josephangbc @daichimukai