fix: subnet genesis file error (#368)

crates/topos/src/components/node/mod.rs

@@ -115,11 +115,23 @@ pub(crate) async fn handle_command(
             );
 
             // Load genesis pointed by the local config
-            let genesis = Genesis::new(
-                home.join("subnet")
-                    .join(config.base.subnet.clone())
-                    .join("genesis.json"),
-            );
+            let genesis_file_path = home
+                .join("subnet")
+                .join(config.base.subnet.clone())
+                .join("genesis.json");
+            let genesis = match Genesis::new(genesis_file_path.clone()) {
+                Ok(genesis) => genesis,
+                Err(_) => {
+                    error!(
+                        "Could not load genesis.json file on path {} \n Please make sure to have \
+                         a valid genesis.json file for your subnet in the {}/subnet/{} folder.",
+                        genesis_file_path.display(),
+                        home.display(),
+                        &config.base.subnet
+                    );
+                    std::process::exit(1);
+                }
+            };
 
             // Get secrets
             let keys = match &config.base.secrets_config {

crates/topos/src/config/genesis/mod.rs

@@ -1,5 +1,4 @@
 use rlp::Rlp;
-use serde::{Deserialize, Serialize};
 use std::collections::HashSet;
 use std::str::FromStr;
 use std::{fs, path::PathBuf};
@@ -18,19 +17,23 @@ pub struct Genesis {
     pub json: Value,
 }
 
-#[derive(Debug, Serialize, Deserialize)]
+#[derive(Debug, thiserror::Error)]
 pub enum Error {
+    #[error("Failed to parse validators")]
     ParseValidators,
+    #[error("Invalid genesis file on path {0}: {1}")]
+    InvalidGenesisFile(String, String),
 }
 
 impl Genesis {
-    pub fn new(path: PathBuf) -> Self {
+    pub fn new(path: PathBuf) -> Result<Self, Error> {
         info!("Reading subnet genesis file {}", path.display());
-        let genesis_file = fs::File::open(&path).expect("opened file");
+        let genesis_file = fs::File::open(&path)
+            .map_err(|e| Error::InvalidGenesisFile(path.display().to_string(), e.to_string()))?;
 
         let json: Value = serde_json::from_reader(genesis_file).expect("genesis json parsed");
 
-        Self { path, json }
+        Ok(Self { path, json })
     }
 
     // Considered as being the set of premined addresses for now

crates/topos/src/config/genesis/tests.rs

@@ -15,6 +15,7 @@ macro_rules! test_case {
 #[once]
 pub fn genesis() -> Genesis {
     Genesis::new(test_case!("genesis-example.json").into())
+        .expect("Expected valid test genesis file")
 }
 
 #[rstest]