[872/827] Make staff role fields dependent on staff type #115
Conversation
tm-kn
force-pushed
the
827-staff-role-dependency-on-staff-type
branch
from
31d4446
to
ce5e0fd
Compare
| for staff in records: | ||
| first_role = staff.roles.filter(area__isnull=True).first() | ||
| if first_role is not None: | ||
| first_role.area = staff.area |
There was a problem hiding this comment.
Don't we need to copy the location field too from the StaffPage? Maybe only if it has one role only?
| first_role = staff.roles.filter(area__isnull=True).first() | ||
| if first_role is not None: | ||
| first_role.area = staff.area | ||
| first_role.save() |
There was a problem hiding this comment.
This won't call clean() automatically, so you might want to do that and provide a list of pages that fail the new validation. You could just do that manually too, not necessarily in the migration.
There was a problem hiding this comment.
In the newest diff I moved the validation to forms because it would not validate related models properly. I don't think we need to call clean(). Some of the data can stay even if it's not supposed to be there. It will just add unnecessary complexity and if page will be saved later on in the admin site, it'll delete those entries anyway and it will be invisible process.
I also improved migrations to copy location and update draft versions of the pages too.
There's a lot of page that seem that they need upgrading and it's easy enough to make it as migration IMO.
tm-kn
force-pushed
the
827-staff-role-dependency-on-staff-type
branch
2 times, most recently
from
1bc961a
to
c6dd3e4
Compare
tm-kn
force-pushed
the
827-staff-role-dependency-on-staff-type
branch
from
c6dd3e4
to
9ee0cd4
Compare
tm-kn
changed the title
No description provided.