Fix simple_httpclient: Improve error reporting on connect timeout#3606
Open
joegasewicz wants to merge 1 commit intotornadoweb:masterfrom
Open
Conversation
joegasewicz
changed the title
joegasewicz
changed the title
joegasewicz
force-pushed
the
fix/imple_httpclient-Improve-error-reporting-on-connect-timeout
branch
from
1c714c2 to
552d38a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #3522
SimpleAsyncHTTPClient currently reports connect timeouts generically as "Timeout while connecting", without distinguishing between DNS resolution and TCP connection phases.
This change introduces phase tracking during the connect process for DNS resolution & TCP connection phases
Timeout errors now include a more specific context of
Timeout during DNS resolutionorTimeout during TCP connection.This should aid debugging issues in environments where DNS latency is a common cause of connect timeouts ie. Kubernetes.
The change should be fully backwards compatible...