Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

120 include codecarbon to pyexperimenter #128

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

LukasFehring
Copy link
Collaborator

@LukasFehring LukasFehring commented May 19, 2023

This branch is already staged on #117

@LukasFehring LukasFehring force-pushed the 120-include-codecarbon-to-pyexperimenter branch from d299bca to 793bd89 Compare May 26, 2023 12:33
Copy link
Owner

@tornede tornede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Default configuration should be tracking_mode=machine.
  • The units should be part of the column names.
  • Please check my latest changes again.

@LukasFehring LukasFehring force-pushed the 120-include-codecarbon-to-pyexperimenter branch 2 times, most recently from c2f69fe to 3afa3c6 Compare June 17, 2023 06:51
@LukasFehring LukasFehring force-pushed the 120-include-codecarbon-to-pyexperimenter branch from 3afa3c6 to 2e20cea Compare June 17, 2023 07:06
@LukasFehring
Copy link
Collaborator Author

I made a minor update in the notebooks. While codecarbon was removed from the logtable notebook it was still in the conditional grid notebook. I changed that

Copy link
Owner

@tornede tornede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tornede tornede merged commit daac6d9 into develop Jun 21, 2023
7 checks passed
@tornede tornede deleted the 120-include-codecarbon-to-pyexperimenter branch June 21, 2023 15:21
@tornede tornede linked an issue Jun 23, 2023 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include CodeCarbon to PyExperimenter
2 participants