Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

161 booelan handling in sqlite #162

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Conversation

LukasFehring
Copy link
Collaborator

@LukasFehring LukasFehring commented Jan 9, 2024

As mentioned in the linked issue, this MR aims to solve the problem that booelans are currently added as strings into the db

Description

Adding values into the database is currently handled by the same function for both sqlite and MySQL. This is adapted to use an abstract function with separate implementations because of the different types.

Motivation and Context

Cuirrently sqlite writes booleans as strings into the db

Type Of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How has This Been Tested?

  • Database provider:
  • Python version:
  • Operating System:

Does this Close/Impact Existing Issues?

What is Missing?

Checklist

  • My change is based on the latest stage of the develop branch.
  • My change required a change of the documentation, which has been done.
  • I checked that the documentation can be build, visualizes everything as expected, and does not contain any warnings.
  • I have added/adapted tests to cover my changes.
  • The tests can be executed successfully.
  • The notebooks can be executed successfully.
  • The notebooks can be executed with mysql as provider.
  • I have added a description of the changes to CHANGELOG.rst.

@LukasFehring LukasFehring linked an issue Jan 9, 2024 that may be closed by this pull request
@LukasFehring LukasFehring changed the title [DRAFT] 161 booelan handling in sqlite 161 booelan handling in sqlite Feb 27, 2024
Copy link
Owner

@tornede tornede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tornede tornede merged commit eac6189 into develop Feb 28, 2024
7 checks passed
@tornede tornede deleted the 161-booelan-handling-in-sqlite branch February 28, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Booelan Handling in SQLITE
2 participants