Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the linked issue, this MR aims to solve the problem that booelans are currently added as strings into the db
Description
Adding values into the database is currently handled by the same function for both sqlite and MySQL. This is adapted to use an abstract function with separate implementations because of the different types.
Motivation and Context
Cuirrently sqlite writes booleans as strings into the db
Type Of Changes
How has This Been Tested?
Does this Close/Impact Existing Issues?
What is Missing?
Checklist
develop
branch.mysql
as provider.CHANGELOG.rst
.