Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log all sql queries #173

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Log all sql queries #173

merged 3 commits into from
Feb 28, 2024

Conversation

LukasFehring
Copy link
Collaborator

@LukasFehring LukasFehring commented Feb 27, 2024

Description

Add logging to every executed SQL statement

Motivation and Context

Makes for easier debugging

Changes

Type Of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How has This Been Tested?

  • Database provider: Any
  • Python version: Any
  • Operating System: Any

What is Missing?

Nothing

Checklist

  • My change is based on the latest stage of the develop branch.
  • My change required a change of the documentation, which has been done.
  • I checked that the documentation can be build, visualizes everything as expected, and does not contain any warnings.
  • I have added/adapted tests to cover my changes.
  • The tests can be executed successfully.
  • The notebooks can be executed successfully.
  • The notebooks can be executed with mysql as provider.
  • I have added a description of the changes to CHANGELOG.rst.

Copy link
Owner

@tornede tornede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tornede tornede merged commit 34afe33 into develop Feb 28, 2024
6 of 7 checks passed
@tornede tornede deleted the log_all_sql_queries branch February 28, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants