Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Problem in merge #177

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Fix Problem in merge #177

merged 3 commits into from
Mar 7, 2024

Conversation

LukasFehring
Copy link
Collaborator

@LukasFehring LukasFehring commented Mar 5, 2024

During merging the "For Update" functionality stopped being used in mysql. I also added a test case

Description

Use For Update again

Motivation and Context

Experiments got pulled multiple times

Changes

The function _get_pull_experiment_query was not used after the merge. I put it back into the code. I also added a test case, that raises an error if an experiment is pulled multiple times.

Type Of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How has This Been Tested?

  • Database provider: mysql
  • Python version: Any
  • Operating System: Any

Does this Close/Impact Existing Issues?

Solves #174

What is Missing?

Checklist

  • My change is based on the latest stage of the develop branch.
  • My change required a change of the documentation, which has been done.
  • I checked that the documentation can be build, visualizes everything as expected, and does not contain any warnings.
  • I have added/adapted tests to cover my changes.
  • The tests can be executed successfully.
  • The notebooks can be executed successfully.
  • The notebooks can be executed with mysql as provider.
  • I have added a description of the changes to CHANGELOG.rst.

During merging the "For Update" functionality stopped beeing used in mysql.
Add testcase
@LukasFehring LukasFehring linked an issue Mar 5, 2024 that may be closed by this pull request
@LukasFehring LukasFehring changed the title Fix Problem in merge [DRAFT ]Fix Problem in merge Mar 5, 2024
@LukasFehring LukasFehring changed the title [DRAFT ]Fix Problem in merge Fix Problem in merge Mar 5, 2024
Copy link
Owner

@tornede tornede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tornede tornede merged commit df3931f into develop Mar 7, 2024
7 checks passed
@tornede tornede deleted the 174-n_jobs-not-working-as-expected branch March 7, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

n_jobs not working as expected
2 participants