Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

178 ssh minor probelms #179

Merged
merged 2 commits into from
Mar 8, 2024
Merged

178 ssh minor probelms #179

merged 2 commits into from
Mar 8, 2024

Conversation

tornede
Copy link
Owner

@tornede tornede commented Mar 8, 2024 •
edited
Loading

Description

There was a slight mistake in the ssh documentation.
We wrongly provide sshtunnel with the pkey parameter instead of ssh_private_key_password

Motivation and Context

Changes

Type Of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How has This Been Tested?

  • Database provider:
  • Python version:
  • Operating System:

Does this Close/Impact Existing Issues?

What is Missing?

Checklist

  • My change is based on the latest stage of the develop branch.
  • My change required a change of the documentation, which has been done.
  • I checked that the documentation can be build, visualizes everything as expected, and does not contain any warnings.
  • I have added/adapted tests to cover my changes.
  • The tests can be executed successfully.
  • The notebooks can be executed successfully.
  • The notebooks can be executed with mysql as provider.
  • I have added a description of the changes to CHANGELOG.rst.

@tornede tornede linked an issue Mar 8, 2024 that may be closed by this pull request
Ssh Minor Problems #178
Closed
tornede
tornede commented Mar 8, 2024
View reviewed changes
Copy link
Owner Author

@tornede tornede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tornede tornede merged commit d0f0a92 into develop Mar 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ssh Minor Problems
2 participants
@tornede @LukasFehring