Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experiment and execute functionality #194

Merged
merged 10 commits into from
Jun 3, 2024

Conversation

tornede
Copy link
Owner

@tornede tornede commented Apr 17, 2024

Description

I added two functions.

  1. A function to create a database without directly adding experiment instances called create_table.
  2. A function to add a configuration to the database, and immediately execute it. Note that the status of the experiment is set to CREATED_FOR_EXECUTION, and immediately executed.

Motivation and Context

An additional state is useful for possible error handling. Otherwise the changes are motivated by the Feature Request.

Type Of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How has This Been Tested?

  • Database provider: MySQL and SQLITE
  • Python version: 3.9
  • Operating System: Linux Ubuntu

Does this Close/Impact Existing Issues?

This implementation fulfils the request

Checklist

  • My change is based on the latest stage of the develop branch.
  • My change required a change of the documentation, which has been done.
  • I checked that the documentation can be build, visualizes everything as expected, and does not contain any warnings.
  • I have added/adapted tests to cover my changes.
  • The tests can be executed successfully.
  • The notebooks can be executed successfully.
  • The notebooks can be executed with mysql as provider.
  • I have added a description of the changes to CHANGELOG.rst.

Copy link
Owner Author

@tornede tornede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tornede tornede merged commit 0cfb381 into develop Jun 3, 2024
12 checks passed
@tornede tornede deleted the add-new-experiment-and-start-immediately branch June 3, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants