Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimises fnd call if node details passed in the constructor #371

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Optimises fnd call if node details passed in the constructor #371

merged 3 commits into from
Oct 4, 2024

Conversation

arch1995
Copy link
Contributor

@arch1995 arch1995 commented Oct 3, 2024 •
edited
Loading

Motivation and Context

Replaces fnd call with local config.

Jira Link: https://toruslabs.atlassian.net/browse/PD-3963

Description

Replaces fnd call with local config

How has this been tested?

Developer tested this manually.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@arch1995 arch1995 self-assigned this Oct 3, 2024
@arch1995 arch1995 changed the title Removes fnd call Optimises fnd call if node details passed in the constructor Oct 3, 2024
himanshuchawla009
himanshuchawla009 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@himanshuchawla009 himanshuchawla009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@himanshuchawla009 himanshuchawla009 merged commit a81c023 into master Oct 4, 2024
1 check passed
@himanshuchawla009 himanshuchawla009 deleted the feat/remove-fnd-call branch October 4, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshuchawla009 himanshuchawla009 himanshuchawla009 approved these changes

Assignees

@arch1995 arch1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arch1995 @himanshuchawla009