Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have toc_only return an empty string when toc is disabled #77

Merged
merged 1 commit into from
Mar 23, 2019

Conversation

gandalf3
Copy link

No description provided.

Copy link
Owner

@toshimaru toshimaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. (I am going to change CodeClimate setting for CI)

@toshimaru
Copy link
Owner

I'm gonna add tests for this change. Let's get this merged.

@toshimaru toshimaru merged commit 612513c into toshimaru:master Mar 23, 2019
@gandalf3 gandalf3 deleted the toc_only_disable_fix branch March 23, 2019 02:32
toshimaru added a commit that referenced this pull request Mar 23, 2019
@toshimaru toshimaru mentioned this pull request Mar 23, 2019
toshimaru added a commit that referenced this pull request Mar 23, 2019
@toshimaru
Copy link
Owner

@gandalf3 Thanks for reporting issue and sending PR ❤️
v0.10.0 has been released!!

@gandalf3
Copy link
Author

@toshimaru Awesome, thanks!
By the way, I'm not sure if you saw my other PR: #75?

@toshimaru
Copy link
Owner

if you saw my other PR: #75?

I'm still considering how it should be implemented..., Hold on please. 🙏

@gandalf3
Copy link
Author

Of course, no rush!

N7K4 pushed a commit to n13org/jekyll-toc-navtotop that referenced this pull request Feb 29, 2020
Have toc_only return an empty string when toc is disabled
N7K4 pushed a commit to n13org/jekyll-toc-navtotop that referenced this pull request Feb 29, 2020
N7K4 pushed a commit to n13org/jekyll-toc-navtotop that referenced this pull request Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants