Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 문서에서 사용해볼 수 있는 데모 추가 #210

Merged
merged 17 commits into from
Aug 7, 2024

Conversation

kangju2000
Copy link
Contributor

@kangju2000 kangju2000 commented Aug 1, 2024

Overview

문서에서 사용해볼 수 있는 데모를 추가합니다.
(amountToHangul, canBe~, disassemble, disassembleToGroups, getChoseong, hasBatchim, romanize, standardizePronunciation, susa)

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

changeset-bot bot commented Aug 1, 2024

🦋 Changeset detected

Latest commit: 4a29005

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 4:03pm

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.82%. Comparing base (accc087) to head (4a29005).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #210   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files          29       29           
  Lines         585      585           
  Branches      142      142           
=======================================
  Hits          584      584           
  Misses          1        1           

@okinawaa
Copy link
Member

okinawaa commented Aug 2, 2024

너무나 좋은 작업 감사해요.
빠른 시일내에 #189 PR이 머지되어 es-hangul은 불필요한 함수를 제거하고, 함수명을 변경하려고하는데요 이 PR에서 작업해주신 함수들도 이번 v2로의 변경사항에 포함되는 함수들이 많이 보이는것 같아요.
대부분 이름이 변경되거나, 함수가 삭제될 것 같은데. v2가 머지되고 이 PR은 다시 살펴봐도 될까요?

@kangju2000
Copy link
Contributor Author

너무나 좋은 작업 감사해요. 빠른 시일내에 #189 PR이 머지되어 es-hangul은 불필요한 함수를 제거하고, 함수명을 변경하려고하는데요 이 PR에서 작업해주신 함수들도 이번 v2로의 변경사항에 포함되는 함수들이 많이 보이는것 같아요. 대부분 이름이 변경되거나, 함수가 삭제될 것 같은데. v2가 머지되고 이 PR은 다시 살펴봐도 될까요?

@okinawaa 좋아요! v2 머지되면 변경사항에 맞게 다시 작업할게요!

@kangju2000 kangju2000 changed the title docs: 문서에서 사용해볼 수 있는 데모 추가 (acronymizehangul, disassembleHangul, disassembleHangulToGroups, extractHangul, hangulIncludes) docs: 문서에서 사용해볼 수 있는 데모 추가 (amountToHangul, disassemble, disassembleToGroups, getChoseong) Aug 6, 2024
@kangju2000 kangju2000 changed the title docs: 문서에서 사용해볼 수 있는 데모 추가 (amountToHangul, disassemble, disassembleToGroups, getChoseong) docs: 문서에서 사용해볼 수 있는 데모 추가 (amountToHangul, disassemble, disassembleToGroups, getChoseong, romanize, standardizePronunciation, susa) Aug 6, 2024
@kangju2000 kangju2000 changed the title docs: 문서에서 사용해볼 수 있는 데모 추가 (amountToHangul, disassemble, disassembleToGroups, getChoseong, romanize, standardizePronunciation, susa) docs: 문서에서 사용해볼 수 있는 데모 추가 (amountToHangul, disassemble, disassembleToGroups, getChoseong, hasBatchim romanize, standardizePronunciation, susa) Aug 6, 2024
@kangju2000 kangju2000 changed the title docs: 문서에서 사용해볼 수 있는 데모 추가 (amountToHangul, disassemble, disassembleToGroups, getChoseong, hasBatchim romanize, standardizePronunciation, susa) docs: 문서에서 사용해볼 수 있는 데모 추가 (amountToHangul, disassemble, disassembleToGroups, getChoseong, hasBatchim, romanize, standardizePronunciation, susa) Aug 6, 2024
@kangju2000 kangju2000 changed the title docs: 문서에서 사용해볼 수 있는 데모 추가 (amountToHangul, disassemble, disassembleToGroups, getChoseong, hasBatchim, romanize, standardizePronunciation, susa) docs: 문서에서 사용해볼 수 있는 데모 추가 Aug 6, 2024
@kangju2000
Copy link
Contributor Author

@okinawaa
v2에 맞춰 업데이트 해두었습니다!

Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 값진 작업 감사합니다!!

@okinawaa okinawaa merged commit 65e2c7c into toss:main Aug 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants