Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: docs, changeset scripts 추가 #220

Merged
merged 6 commits into from
Aug 16, 2024

Conversation

anonymousRecords
Copy link
Contributor

Overview

더 편리하게 오픈소스에 기여할 수 있다고 생각해서,
changeset, doc 관련하여 스크립트를 추가했습니다.

변경 전

  "scripts": {
    "attw": "attw --pack",
    "build": "tsup",
    "changeset:publish": "changeset publish",
    "changeset:version": "changeset version",
    "packlint": "packlint sort -R",
    "publint": "publint --strict",
    "test": "vitest run --coverage --typecheck",
    "test:watch": "vitest --ui --coverage --typecheck",
    "typecheck": "tsc --noEmit"
  },

변경 후

  "scripts": {
    ...
    "changeset": "changeset",
    "changeset:add": "changeset add",
    ...
    "docs:dev": "yarn workspace docs dev",
    "docs:build": "yarn workspace docs build",
    "docs:start": "yarn workspace docs start",
    "predocs:build": "yarn build"  
  },

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

changeset-bot bot commented Aug 5, 2024

🦋 Changeset detected

Latest commit: dfa29f0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 4:14am

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.83%. Comparing base (6e2c8e1) to head (dfa29f0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          31       31           
  Lines         600      600           
  Branches      145      145           
=======================================
  Hits          599      599           
  Misses          1        1           

package.json Outdated Show resolved Hide resolved
.changeset/swift-toys-appear.md Outdated Show resolved Hide resolved
@anonymousRecords
Copy link
Contributor Author

@okinawaa

피드백 확인하고 아래와 같이 수정했습니다.

  1. 불필요한 중복을 야기할 수 있어서 "predocs:build": "yarn build" 제거
  2. changeset 관련 스크립트 제거

요건 어떤 용도인가용? 현재 yarn build하면 가장 위 스크립트인 tsup이 실행되도록 되어있어서요!

언급해 주신 부분은 제가 중복 야기하는지 확인을 못 했었어서 제거했습니당

Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

늦게 확인하여 죄송합니다!
정말 감사합니다~!

@okinawaa okinawaa merged commit ba8be13 into toss:main Aug 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants