Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename I => index #221

Merged
merged 1 commit into from
Aug 5, 2024
Merged

chore: rename I => index #221

merged 1 commit into from
Aug 5, 2024

Conversation

2wheeh
Copy link
Contributor

@2wheeh 2wheeh commented Aug 5, 2024

Overview

  • 대문자 I는 숫자 1이나 소문자 l과 혼동될 수 있음
  • 일반 변수의 네이밍 컨벤션은 카멜케이스를 따름

위의 이유로 변수명을 변경합니다.

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

changeset-bot bot commented Aug 5, 2024

⚠️ No Changeset found

Latest commit: 4cfec90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 9:33am

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.61%. Comparing base (26552bb) to head (4cfec90).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files          32       32           
  Lines         629      629           
  Branches      146      146           
=======================================
  Hits          614      614           
  Misses         14       14           
  Partials        1        1           

@2wheeh 2wheeh changed the title refactor: rename I => index chore: rename I => index Aug 5, 2024
Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다

@okinawaa okinawaa merged commit 78cde66 into toss:main Aug 5, 2024
10 checks passed
@2wheeh 2wheeh deleted the rename-i branch August 5, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants