Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 단독으로 존재하는 겹자음의 romanize 지원 #222

Closed
wants to merge 4 commits into from

Conversation

2wheeh
Copy link
Contributor

@2wheeh 2wheeh commented Aug 5, 2024

Overview

romanize 함수가 단독으로 존재하는 자음을 처리하는 로직을 개선합니다.

이제 단독으로 존재하는 겹자음의 경우도 처리가 가능합니다.

기존: =>
변경: => gs

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

changeset-bot bot commented Aug 5, 2024

⚠️ No Changeset found

Latest commit: 40f39a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 5:31pm

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.62%. Comparing base (78cde66) to head (40f39a8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
+ Coverage   97.61%   97.62%   +0.01%     
==========================================
  Files          32       32              
  Lines         629      632       +3     
  Branches      146      146              
==========================================
+ Hits          614      617       +3     
  Misses         14       14              
  Partials        1        1              

@2wheeh 2wheeh changed the title feat: 단독으로 존재하는 겹자음의 romanize 지원 fix: 단독으로 존재하는 겹자음의 romanize 지원 Aug 5, 2024
@2wheeh 2wheeh closed this Aug 5, 2024
@2wheeh 2wheeh deleted the romanize-support-double-consonant branch August 8, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants