fix: convertQwertyToAlphabet 오타 수정 #249
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
=======================================
Coverage 99.66% 99.66%
=======================================
Files 36 36
Lines 601 601
Branches 145 145
=======================================
Hits 599 599
Misses 2 2 |
| @@ -28,4 +28,4 @@ export function convertQwertyToHangul(word: string): string { | |||
| return ''; | |||
| } | |||
| return assemble([...convertQwertyToAlphabet(word)]); | |||
| } | |||
| } | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
넵 덕분에 배워갑니다!!
docs/CHANGELOG.md
Outdated
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| - [#209](https://github.com/toss/es-hangul/pull/209) [`c15a9d1`](https://github.com/toss/es-hangul/commit/c15a9d18cff0bc36f7672f3d6ab38e422a625d34) Thanks [@kangju2000](https://github.com/kangju2000)! - docs: josa, josa.pick 문서에 demo를 추가합니다. | |||
|
|
|||
| - [#205](https://github.com/toss/es-hangul/pull/205) [`75ef7df`](https://github.com/toss/es-hangul/commit/75ef7dfb1e1e27f33cb3fb2e4ab3184b6d0901c6) Thanks [@anonymousRecords](https://github.com/anonymousRecords)! - fix : 문서 상단의 깃허브 아이콘이 제대로 보이지 않는 문제를 수정합니다 | |||
| - [#205](https://github.com/toss/es-hangul/pull/205) [`75ef7df`](https://github.com/toss/es-hangul/commit/75ef7dfb1e1e27f33cb3fb2e4ab3184b6d0901c6) Thanks [@anonymousRecords](https://github.com/anonymousRecords)! - fix: 문서 상단의 깃허브 아이콘이 제대로 보이지 않는 문제를 수정합니다 | |||
There was a problem hiding this comment.
CHANGELOG.md는 큰 문제가 있지 않는 한,
수동으로 수정하지 않았으면 좋겠습니다! PR의 제목과 맞춰져있기때문에
달라진다면 예상치 못한 오류가 발생할 수 있다고 생각했어요!
…fix/changelog-and-convertQwertyToAlphabet
This reverts commit 44c5421.
YuHyeonWook
changed the title
|
이전 코드로 되돌리고 오타만 수정했습니닷! |
Overview
PR Checklist