Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: josa.pick메서드를 개발자가 읽고 이해할 수 있도록 문서화를 진행합니다. #85

Merged
merged 1 commit into from
May 14, 2024

Conversation

okinawaa
Copy link
Member

@okinawaa okinawaa commented May 3, 2024

Overview

#35

josa.pick에 대한 문서화가 되어있지 않았습니다.

이미지

image

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

changeset-bot bot commented May 3, 2024

⚠️ No Changeset found

Latest commit: 4bb2aec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview May 3, 2024 2:53pm

@okinawaa
Copy link
Member Author

okinawaa commented May 3, 2024

메서드의 행동을 설명하는데 어색한 부분이 있다면, 코맨트 부탁드립니다!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1292575) to head (4bb2aec).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #85   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          204       204           
  Branches        45        45           
=========================================
  Hits           204       204           

Copy link
Member

@evan-moon evan-moon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@youngjae99 youngjae99 merged commit 0d89b06 into main May 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants