Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error-boundary): remove unnecessary comment #192

Merged

Conversation

manudeli
Copy link
Member

@manudeli manudeli commented Jan 23, 2023

Overview

Remove unnecessary comment

When I click link of comment, I can't understand what this comment mean.
If it have meaning, how about clarifying it?

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@netlify
Copy link

netlify bot commented Jan 23, 2023

Deploy Preview for slash-libraries ready!

Name Link
🔨 Latest commit 2bf8fb7
🔍 Latest deploy log https://app.netlify.com/sites/slash-libraries/deploys/63cfeb61e420f30009512e45
😎 Deploy Preview https://deploy-preview-192--slash-libraries.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@okinawaa
Copy link
Member

cool! I agree with you

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think due to updates to react-error-boundary, the link is now broken. We might delete this now.

@raon0211 raon0211 merged commit f9d16f2 into toss:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants