-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(error-boundary): optimize return of useErrorBoundaryGroup #200
perf(error-boundary): optimize return of useErrorBoundaryGroup #200
Conversation
👷 Deploy request for slash-libraries pending review.Visit the deploys page to approve it
|
Thank you for your good opinion! You are currently returning an object containing only reset. Rather, I think it will cost more to optimize! If more expensive logic is included in the object in the future, it will be effective, but at the moment, it will have a negative effect, what do you think?!
|
f840466
to
771ad25
Compare
I intended that useErrorBoundaryGroup returning object's reference need to be same until It need to be refresh during rendering. |
It's a good idea to keep the same reference it is semantically effective! It was nice to have a useful meeting together! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Overview
Optimize return of useErrorBoundaryGroup by using useMemo
AS-IS
TO-BE
PR Checklist