Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix installation of extras with underscore #3397

Closed
wants to merge 2 commits into from
Closed

Fix installation of extras with underscore #3397

wants to merge 2 commits into from

Conversation

zariiii9003
Copy link

Fixes #3396

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

gaborbernat
gaborbernat requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test please.

@gaborbernat gaborbernat marked this pull request as draft October 7, 2024 21:29
@zariiii9003
Copy link
Author

Even without my changes i get 196 failed tests if i run the test suite locally. Also i don't know where and how to test this. Closing 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat requested changes

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extras with underscore are not installed
2 participants
@zariiii9003 @gaborbernat