Skip to content

Conversation

salahcoronya
Copy link

No description provided.

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be35c35) 78.17% compared to head (e79db5a) 78.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   78.17%   78.17%           
=======================================
  Files          17       17           
  Lines        2667     2667           
=======================================
  Hits         2085     2085           
  Misses        582      582           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Christopher Byrne <salah.coronya@gmail.com>
@AndreasFuchsTPM
Copy link
Member

Could you give some more information and rational for this change ?
What is the issue with -no-undefined which is something I'd usually assume a good test.
Also, could we make this change conditional ?

@salahcoronya
Copy link
Author

In GNU libtool, -no-undefined does nothing. See https://wiki.gentoo.org/wiki/Slibtool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants