TPM key import #194
TPM key import #194
Conversation
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
==========================================
+ Coverage 67.71% 67.84% +0.12%
==========================================
Files 8 8
Lines 1112 1160 +48
==========================================
+ Hits 753 787 +34
- Misses 359 373 +14
Continue to review full report at Codecov.
|
|
Awesome ! Thanks for taking up this task. I'd be fine with using -u and -r for the keyfiles. Please also sQuash both commits into one with you as the author. You can add the other authors using a I'll be VERY happy to merge this then. :-) |
gotthardp
force-pushed
the
key_import
branch
3 times, most recently
from
05c1ed0
to
a75fe8c
Compare
Introduce a possibility to import keys created e.g. with tpm2_create. Consumes the public (-u) and private (-r) portion of the TPM key and produces the 'TSS2 PRIVATE KEY' file. Signed-off-by: Petr Gotthard <petr.gotthard@centrum.cz> Co-authored-by: Andreas Fuchs <andreas.fuchs@sit.fraunhofer.de> Co-authored-by: Takahide Higuchi <takahidehiguchi@gmail.com>
|
LGTM, we'll see what CI has to say and if Andreas has anymore feedback. |
|
I used this to test GH Actions since it was an approved PR. Its been moved over to here and merged: |
May I help finalizing the import feature (#39), please? I took over the content of the #140 and fixed (most of the) review comments, except the following.
Pending questions:
"Can't we just import a public key only?" (@williamcroberts) -- Right now the tpm2tss-genkey generates both public and private portion. Consistently with this, the import function lets the user to import public&private portion of a pre-existing key.
"Shouldn't we make the arguments make consistent with tpm2-tools?" (@gotthardp) The tpm2-tools consistently use
-ufor the public portion and-rfor the private portion. I'd suggest to stick to this convention and use -u/-r instead of -i/-k. Would you agree?Is there anything else that should be addressed?