src: Check if NID_sm2 is defined #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NID_sm2 algorithm is not currently supported by LibreSSL which causes build failures. However instead of checking the OpenSSL version number it is possible to just check if NID_sm2 is defined instead. This way it will be automatically enabled when LibreSSL does support it and disabled in the event the OpenSSL stops supporting it. LibreSSL issue: libressl/portable#841 Signed-off-by: orbea <orbea@riseup.net>
Codecov Report
@@ Coverage Diff @@
## master #2602 +/- ##
=======================================
Coverage 83.60% 83.61%
=======================================
Files 363 363
Lines 41686 41686
=======================================
+ Hits 34851 34855 +4
+ Misses 6835 6831 -4
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JuergenReppSIT
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NID_sm2 algorithm is not currently supported by LibreSSL which causes build failures. However instead of checking the OpenSSL version number it is possible to just check if NID_sm2 is defined instead. This way it will be automatically enabled when LibreSSL does support it and disabled in the event the OpenSSL stops supporting it.
LibreSSL issue: libressl/portable#841
I am splitting this off from PR #2380 since it is more general.