Add support for Attestable TPM changes in latest TPM spec #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Andersen <jeffandersen@google.com>
bluegate010
force-pushed
the
attestable-tpm
branch
from
0bfed17 to
7552d0b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2729 +/- ##
==========================================
- Coverage 82.59% 82.55% -0.05%
==========================================
Files 369 369
Lines 43125 43149 +24
==========================================
+ Hits 35619 35620 +1
- Misses 7506 7529 +23 ☔ View full report in Codecov by Sentry. |
williamcroberts
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
LGTM lets let @AndreasFuchsTPM or @JuergenReppSIT double check me since they have been following stuff more closely.
| #define ESYS_TR_RH_SVN_OWNER_BASE 0x1010000U | ||
| #define ESYS_TR_RH_SVN_ENDORSEMENT_BASE 0x1020000U | ||
| #define ESYS_TR_RH_SVN_PLATFORM_BASE 0x1030000U | ||
| #define ESYS_TR_RH_SVN_NULL_BASE 0x1040000U |
There was a problem hiding this comment.
AFAICT this fits nicely in the ESYS_TR "namespace" and won't conflict with the random() offset for non-permanent handles:
tpm2-tss/src/tss2-esys/esys_context.c
Line 79 in 166a553
This is more of a note for other reviewers to consider this than a comment on the patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.