FAPI: Add new profiles P_RSA3072SHA384 P_ECCP384SHA384 #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JuergenReppSIT
commented
Feb 12, 2024
•
JuergenReppSIT
commented
- The new profiles are added to the dist directory.
- The key size 3072 and 4092 is added to the json serialization and deserialization.
- The integration tests are adapted to enable usage of P_RSA3072 as default profile.
- The state handling in the state machines of the policy utilities is fixed.
- The policy error handling has been cleaned up
JuergenReppSIT
force-pushed
the
fapi-add-new-dist-profiles
branch
from
f968840 to
6c9188b
Compare
JuergenReppSIT
force-pushed
the
fapi-add-new-dist-profiles
branch
3 times, most recently
from
f13d4ad to
2149fb1
Compare
* The new profiles are added to the dist directory. * The key size 3072 and 4092 is added to the json serialization and deserialization. * The unused parameter session_hash_alg is removed from P_RSA2048SHA256. * Unnecessary commas have been removed from the profiles Signed-off-by: Juergen Repp <juergen_repp@web.de>
JuergenReppSIT
force-pushed
the
fapi-add-new-dist-profiles
branch
from
2149fb1 to
2a99130
Compare
The compiler errors maybe unused with gcc version 12.2.0 (Debian 12.2.0-14) are fixed. Signed-off-by: Juergen Repp <juergen_repp@web.de>
* The test were a sha1 bank is needed are skippd. * Policy usuage is adapted. Signed-off-by: Juergen Repp <juergen_repp@web.de>
JuergenReppSIT
force-pushed
the
fapi-add-new-dist-profiles
branch
from
a43c33c to
d98ea00
Compare
JuergenReppSIT
changed the title
JuergenReppSIT
force-pushed
the
fapi-add-new-dist-profiles
branch
from
68f6779 to
1ed4935
Compare
json-c versions < 0.13 are not supported. In these versions it was not possible to check the result of json_object_object_add. The check is now added. Signed-off-by: Juergen Repp <juergen_repp@web.de>
JuergenReppSIT
force-pushed
the
fapi-add-new-dist-profiles
branch
from
1ed4935 to
c28a374
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Various errors occurred during policy error handling. The flush for esys policy objects was sometimes executed several times. The policy error handling is now unified. Unneeded duplicate code is removed. Unneeded code is removed. The state was not initialized correctly in error cases in the policy utility state machines. Signed-off-by: Juergen Repp <juergen_repp@web.de>
JuergenReppSIT
force-pushed
the
fapi-add-new-dist-profiles
branch
from
c28a374 to
f87820d
Compare
AndreasFuchsTPM
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.