Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCTI: Fix leak produced in Tss2_TctiLdr_Initialize_Ex #2846

Merged

Conversation

JuergenReppSIT
Copy link
Member

The return code of tctildr_init_context_data was not checked in Tss2_TctiLdr_Initialize_Ex. The cleanup part of this function was not executed and so a leak was produced.
Fixes #2842

The return code of tctildr_init_context_data was not checked in
Tss2_TctiLdr_Initialize_Ex. The cleanup part of this function was
not executed and so a leak was produced.
Fixes tpm2-software#2842

Signed-off-by: Juergen Repp <juergen_repp@web.de>
@JuergenReppSIT JuergenReppSIT force-pushed the fix-tcti-leak-on-failure branch from 0090da0 to 7089dbd Compare May 19, 2024 08:41
@JuergenReppSIT JuergenReppSIT requested a review from joholl May 19, 2024 09:25
Copy link
Collaborator

@joholl joholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JuergenReppSIT JuergenReppSIT merged commit e625875 into tpm2-software:master May 19, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak in error path of Esys_Initialize
2 participants