-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SHA1 from tests #2865
Remove SHA1 from tests #2865
Conversation
To fix the failure in test/unit/tss2_policy.c in the function |
Signed-off-by: Johannes Holland <johannes.holland@infineon.de>
We forgot to input the old policyDigest for the hash calculation of the new policyDigest. Bug was not caught due to missing return code assignment in policy-execute, see 80ffbf825f127. Fixes: tpm2-software#2862 Signed-off-by: Johannes Holland <johannes.holland@infineon.de>
Also add some comments about hardcoded keys. Signed-off-by: Johannes Holland <johannes.holland@infineon.de>
Signed-off-by: Johannes Holland <johannes.holland@infineon.de>
Signed-off-by: Johannes Holland <johannes.holland@infineon.de>
Thanks, @JuergenReppSIT, fixed that. Btw: In this PR, I also fixed the |
Signed-off-by: Johannes Holland <johannes.holland@infineon.de>
Added a few commits for tpmclient. Now the test suite is SHA1-free for me. Also saw a problem with tpmclient and libtpms. Fixed it, so now tpmclient can (actually) reset libtpms. |
|
Signed-off-by: Johannes Holland <johannes.holland@infineon.de>
Signed-off-by: Johannes Holland <johannes.holland@infineon.de>
I have tested the PR with a physical TPM with the following findings:
|
CI is green now. @AndreasFuchsTPM @JuergenReppSIT Feel free to review. Please note the digests which I just appended |
This has proven very tricky. Due to the sheer amount of SHA1 use, I could not understand every test case in depth.
TPM2_RC_COMMAND_CODE
for three testsFixes: #2818
Fixes: #2862